[ciapug] Peer review of PHP code

Claus ciapug@cialug.org
Tue, 13 Apr 2004 10:23:10 -0500


The code does not contain repeated echo "\n"; statements.  HTML is 
printed via echo and is terminated with the newline so that the html 
source code looks nice.  I think you opened it in an web browser instead 
of an text editor.  :)

The file extention .html may be a little confusing but that way the page 
looks like a generic html file to the end user.  I like to hide 
implementations as much as possible to the end user.

   Claus

On 4/12/2004 5:04 PM, David Champion wrote:

> I would suggest... just for readability:
> 
> change -
> 
> echo " \n"; echo " \n"; echo " \n"; echo " \n"; echo " \n"; echo " \n"; ...
> 
> to -
> echo "\n\n\n\n\n\n";
> 
> Should give you the same results.
> 
> Or you could get fancy and write a function to generate newlines, and 
> pass it the # of lines you want. :p
> 
> -dc
>